Improve database download prompt when creating query #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the skeleton query wizard to not prompt for database download after creating a query by default. Instead, it will show a message with a button to download a database which will launch the same prompt.
shati-patel
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Thanks for this! A couple of comments from me. I also agree that the notifications are a bit wordy, but I don't have much inspiration for other options 😅
@jf205, do you have any opinions about the notification wording now that you can see them "in action"? 📝
extensions/ql-vscode/src/local-queries/skeleton-query-wizard.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/local-queries/skeleton-query-wizard.ts
Outdated
Show resolved
Hide resolved
Comment on lines
338
to
342
| const openFileArgs = [ | ||
| join(this.qlPackStoragePath, this.folderName, this.fileName), | ||
| ]; | ||
| const queryString = encodeURI(JSON.stringify(openFileArgs)); | ||
| return `[${this.fileName}](command:vscode.open?${queryString})`; |
There was a problem hiding this comment.
I can't open the file from this link. I haven't looked into debugging this myself yet (happy to help if need be!) but definitely looks like a windows path issue 😅
There was a problem hiding this comment.
I've tried using a URI to fix this. Let me know if it doesn't work, then we can pair on getting it to work on Windows.
There was a problem hiding this comment.
Works for me now! Thanks ✨
shati-patel
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the database download prompt when creating a query by removing it from the default flow. Instead, the user will get a notification with information on how they can download a database. There are 3 scenarios:
No notification
I'm very open to suggestions on how to better phrase these notifications, they are currently a bit wordy and repetitive.
Checklist
ready-for-doc-reviewlabel there.