Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multiple models feature #3019

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Enable multiple models feature #3019

merged 1 commit into from
Oct 26, 2023

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Oct 26, 2023

Enable the multiple models feature for the model editor and panels.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner October 26, 2023 08:34
robertbrignull
robertbrignull previously approved these changes Oct 26, 2023
View reviewed changes
@charisk charisk force-pushed the charisk/enable-multiple-models branch from 0e30743 to bc83c87 Compare October 26, 2023 08:39
@robertbrignull robertbrignull dismissed their stale review October 26, 2023 08:46

This needs to be based on isCanary rather than just true

@charisk charisk force-pushed the charisk/enable-multiple-models branch from bc83c87 to 6d4fd69 Compare October 26, 2023 08:50
robertbrignull
robertbrignull approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's working for me. The multiple methods only show up when the canary flag is enabled.

@charisk charisk enabled auto-merge (squash) October 26, 2023 09:02
@charisk charisk merged commit 234498a into main Oct 26, 2023
14 checks passed
@charisk charisk deleted the charisk/enable-multiple-models branch October 26, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charisk @robertbrignull