Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor model editor predicates #3020

Merged
merged 8 commits into from
Oct 27, 2023
Merged

Refactor model editor predicates #3020

merged 8 commits into from
Oct 27, 2023

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Oct 26, 2023 •
edited
Loading

This refactors the model editor predicates file to make it easier to add languages with a different format. The Java and C# MaD formats are now in a file for static languages and the format is retrieved through a getModelsAsDataLanguage model. This also makes it possible to have different supported kinds per language.

It's easiest to review this commit-by-commit.

Split out from #3017

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review October 26, 2023 09:58
@koesie10 koesie10 requested a review from a team as a code owner October 26, 2023 09:58
@koesie10 koesie10 requested a review from starcke October 26, 2023 09:58
starcke
starcke approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Just some minor comments/questions.

extensions/ql-vscode/src/model-editor/flow-model-queries.ts Outdated Show resolved Hide resolved
extensions/ql-vscode/src/model-editor/yaml.ts Show resolved Hide resolved
extensions/ql-vscode/src/model-editor/method-modeling/method-modeling-view-provider.ts Outdated Show resolved Hide resolved
extensions/ql-vscode/src/model-editor/method-modeling/method-modeling-view-provider.ts Outdated Show resolved Hide resolved
extensions/ql-vscode/src/model-editor/method-modeling/method-modeling-view-provider.ts Outdated Show resolved Hide resolved
@koesie10 koesie10 enabled auto-merge October 27, 2023 08:27
@koesie10 koesie10 merged commit 1404ab4 into main Oct 27, 2023
@koesie10 koesie10 deleted the koesie10/refactor-predicates branch October 27, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starcke starcke starcke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @starcke