Use transient props for all styled components #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `disabled` prop from the `Dropdown` component. This is already included in the default HTML props of the `select` component, so it's not necessary to add it again.
| @@ -68,7 +68,7 @@ export const VariantAnalysisRepositoriesStats = ({ | |||
| if (variantAnalysisStatus === VariantAnalysisStatus.Failed) { | |||
| return ( | |||
| <> | |||
| 0<HorizontalSpace size={2} /> | |||
There was a problem hiding this comment.
I'm not sure the 0 was a bug. Or if we do want to remove it, do we need to also remove some whitespace before the icon?
It might be simpler regardless to leave it for this PR and address as a separate PR. What do you think?
Screenshot before:
Screenshot after:
There was a problem hiding this comment.
I think you're right. This just looked like an accidental typo, but I didn't actually check whether that was the case.
In this case, I would have expected something like 0 <ErrorIcon label="Variant analysis failed" /> rather than a separate element for the spacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches all styled components I could find with custom props to using transient props. It's easiest to review this commit-by-commit; each commit changes 1 component.
Checklist
ready-for-doc-reviewlabel there.