Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update provenance when inputs change #3064

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Update provenance when inputs change #3064

merged 4 commits into from
Nov 13, 2023

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Nov 10, 2023

Change the provenance from ai-generated/df-generated to ai-manual/df-manual whenever any input changes. Also make sure the provenance remains correct after several updates.

See internal linked issue for discussion/details on the decision.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner November 10, 2023 11:04
norascheuch
norascheuch reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left two suggestions but looks good and increases overall readability I think!

extensions/ql-vscode/src/model-editor/modeled-method.ts Show resolved Hide resolved
extensions/ql-vscode/src/view/model-editor/ModelTypeDropdown.tsx Outdated Show resolved Hide resolved
@charisk
Copy link
Contributor Author

charisk commented Nov 13, 2023

I've made some changes, including some updates to tests. The unit tests don't cover all possible permutations but I think the functionality is covered enough (considering it's a simple switch statement).

norascheuch
norascheuch approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 thanks!

@charisk charisk merged commit 3ac8a81 into main Nov 13, 2023
14 checks passed
@charisk charisk deleted the charisk/povenance-calculations branch November 13, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norascheuch norascheuch norascheuch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charisk @norascheuch