Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workspaceContains:.git activation event #3085

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Remove workspaceContains:.git activation event #3085

merged 1 commit into from
Nov 23, 2023

Conversation

koesie10
Copy link
Member

This removes the workspaceContains:.git activation event since it seems to be conflicting with running CLI tests. When this is present, the extension is activated before the Jest setup script is ran and the incorrect version is retrieved from the CLI.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 requested a review from a team as a code owner November 23, 2023 08:38
charisk
charisk approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@koesie10 koesie10 enabled auto-merge November 23, 2023 08:43
@koesie10 koesie10 merged commit 560008c into main Nov 23, 2023
14 checks passed
@koesie10 koesie10 deleted the koesie10/remove-activation-event branch November 23, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @charisk