Fix tests with workspaceContains:.git activation event
#3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koesie10
force-pushed
the
koesie10/fix-cli-tests
branch
4 times, most recently
from
27bd419 to
0751582
Compare
It seems like changes to the CLI path setting are not picked up by the extension when it is already activated. This is probably because the `workspace.onDidChangeConfiguration` event is not fired when the update is made programmatically. This fixes it by manually firing the event so that all listeners (CLI server, query server, IDE server) can pick up the change.
koesie10
force-pushed
the
koesie10/fix-cli-tests
branch
from
0751582 to
54be065
Compare
charisk
reviewed
Nov 24, 2023
extensions/ql-vscode/test/vscode-tests/cli-integration/databases/database-fetcher.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like changes to the CLI path setting are not picked up by the extension when it is already activated. This is probably because the
workspace.onDidChangeConfigurationevent is not fired when the update is made programmatically.This fixes it by manually firing the event so that all listeners (CLI server, query server, IDE server) can pick up the change.
Some other small changes to the tests were necessary to make everything work (mostly with retries), but this should now work properly.
Checklist
ready-for-doc-reviewlabel there.