-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring needles tester #28
base: main
Are you sure you want to change the base?
Conversation
c6c45e3
to
9fb7f60
Compare
9fb7f60
to
24f84da
Compare
@kedarchandrayan, @pavelkraleu #19 introduced some duplicate methods in |
Hello @LazaroHurtado, thanks for catching the duplicate code. We have made changes in another fork regarding the same already. |
@kedarchandrayan glad to hear! Shouldn't the source repo contain these fixes though? |
Yup, the fork will be merged today! |
Hi @LazaroHurtado, a big change was made today (#33) that has made this pull request outdated. I apologize for the inconvenience. If it is easier, please feel free to open a new pull request with the changes using the latest code. |
I also updated this PR 😄 |
There are some duplicated methods/logic in
LLMMultiNeedleHaystackTester
, this PR is to clean this up. Furthermore, some logging lines get outputted multiple times due to coroutines from asyncio. It is best to remove these lines since they only print what the user has already specified, so no extra information is provided. In the future I plan on adding some debugging support depending on the debug modemain.py
was called with.