Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-character handling in string.utf_codepoint #781

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Fix non-character handling in string.utf_codepoint #781

merged 1 commit into from
Jan 3, 2025

Conversation

mooreryan
Copy link
Contributor

lpil
lpil approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

lpil
lpil reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the changelog please 🙏

@mooreryan
Copy link
Contributor Author

Could you update the changelog please 🙏

Sure! I put it under the ## Unreleased heading. Let me know if I should change that to a different heading, and I will fix it.

@mooreryan @lpil
Fix non-character handling in string.utf_codepoint
2ba40c5 
Treats `U+FFFE` and `U+FFFF` as valid Unicode codepoints rather than errors.  See gleam-lang#778.
@lpil lpil force-pushed the utf_codepoint_fix branch from bb8ec2e to 2ba40c5 Compare January 3, 2025 21:00
lpil
lpil approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@lpil lpil merged commit 6f44f83 into gleam-lang:main Jan 3, 2025
7 checks passed
@mooreryan mooreryan mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mooreryan @lpil