Apply suggestions from code review.

glotzerlab · Nov 5, 2024 · f716ee2 · f716ee2
1 parent 8bae101
commit f716ee2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/freud/order.py b/freud/order.py
@@ -25,10 +25,6 @@
 
 logger = logging.getLogger(__name__)
 
-# numpy must be initialized. When using numpy from C or Cython you must
-# _always_ do that, or you will have segfaults
-# np.import_array()
-
 
 class Cubatic(_Compute):
     r"""Compute the cubatic order parameter :cite:`Haji_Akbari_2015` for a system of

diff --git a/freud/order/Cubatic.cc b/freud/order/Cubatic.cc
@@ -2,7 +2,7 @@
 // This file is from the freud project, released under the BSD 3-Clause License.
 
 #include <cstring>
-#include <functional>
+#include <random>
 #include <stdexcept>
 
 #include "Cubatic.h"
@@ -71,11 +71,7 @@ tensor4 tensor4::operator*(const float& b) const
 
 void tensor4::copyToManagedArray(util::ManagedArray<float>& ma)
 {
-    // TODO: this may be possible with std::copy but this works as well.
-    for (unsigned int i = 0; i < 81; i++)
-    {
-        ma[i] = data[i];
-    }
+    std::copy(data.begin(), data.end(), ma.data());
 }
 
 //! Complete tensor contraction.

diff --git a/freud/order/Cubatic.h b/freud/order/Cubatic.h
@@ -8,7 +8,6 @@
 #include "VectorMath.h"
 #include <array>
 #include <memory>
-#include <random>
 
 /*! \file Cubatic.h
     \brief Compute the cubatic order parameter for each particle.