Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.12 #1166

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Support python 3.12 #1166

merged 2 commits into from
Oct 25, 2023

Conversation

tommy-waltmann
Copy link
Collaborator

Description

This PR adds python 3.12 to our test matrix.

Motivation and Context

Python 3.12 was recently released, and we want to support the newest versions of python.

How Has This Been Tested?

If the existing tests pass, we are good to go.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@tommy-waltmann tommy-waltmann requested a review from a team as a code owner October 19, 2023 21:16
@tommy-waltmann tommy-waltmann requested review from vyasr and removed request for a team October 19, 2023 21:16
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Test are passing here. There must be some issue wit the conda-forge build system and/or pinned dependencies. You can always ask on the conda-forge gitter for support: https://app.gitter.im/#/room/#conda-forge_conda-forge.github.io:gitter.im

We should drop support for Python 3.7. It reached end of life in June 2023.

@tommy-waltmann tommy-waltmann merged commit 38cf373 into master Oct 25, 2023
33 checks passed
@tommy-waltmann tommy-waltmann deleted the support-py-312 branch October 25, 2023 18:26
@tommy-waltmann tommy-waltmann added this to the v2.13.2 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants