Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to disable or restrict users mentions in RichText #18849

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

RomainLvr
Copy link
Contributor

@RomainLvr RomainLvr commented Jan 30, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !35409
  • Here is a brief description of what this PR does

This PR adds the ability to disable or restrict user mentions in RichText of different forms of response in Ticket/Changes/Problems

New option have been added to the Assistance section of profiles:

Dropdown with 3 values :

  • Disabled (Mentions desactivées)
  • Full (Mentions enabled with user list complete)
  • Restricted (Mentions enabled with user list restricted to ticket actors)

Screenshots (if appropriate):

image

image

@RomainLvr RomainLvr requested review from stonebuzz and Rom1-B January 30, 2025 09:06
@RomainLvr RomainLvr self-assigned this Jan 30, 2025
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it also depends on whether the notification is activated, I think you should take the opportunity to add a tooltip (+ a check?).

install/mysql/glpi-empty.sql Outdated Show resolved Hide resolved
@RomainLvr RomainLvr requested a review from Rom1-B January 30, 2025 12:44
src/Profile.php Outdated Show resolved Hide resolved
src/Profile.php Outdated

$description = __s('Enables or disables the ability to mention users within the application.') . "<br><br>";
$description .= "<b>" . __s('Disabled') . "</b> : " . __('User mentions are disabled for this profile.') . "<br><br>";
$description .= "<b>" . __s('Full') . "</b> : " . __('Displays all users.') . "<br><br>";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps specify that the user will be added as an observer if they are not already a ticket actor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants