-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing TTO date in TTO + progress SO when status is waiting #18850
base: 10.0/bugfixes
Are you sure you want to change the base?
Fix missing TTO date in TTO + progress SO when status is waiting #18850
Conversation
src/Search.php
Outdated
@@ -7107,15 +7107,13 @@ public static function giveItem( | |||
$out = Html::convDateTime($data[$ID][0]['name']); | |||
|
|||
// No due date in waiting status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't that affect TTRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've corrected the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we display the TTO here, we should probably also display a progress bar, but with a different color (grey ?) to indicates that the value is not reliable.
Indeed, the waiting time will be added to the TTO when the status of the ticket will change. It mean that the displayed TTO is already stale.
|
Checklist before requesting a review
Please delete options that are not relevant.
Description
Fixed the absence of the TTO date in the TTO + SO progression when the ticket is pending. This was visible with the TTO option, but not with TTO + progress.
Now only the date is displayed (not the progress bar).
Screenshots (if appropriate):