Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing TTO date in TTO + progress SO when status is waiting #18850

Open
wants to merge 3 commits into
base: 10.0/bugfixes
Choose a base branch
from

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Jan 30, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !36138
  • Here is a brief description of what this PR does

Fixed the absence of the TTO date in the TTO + SO progression when the ticket is pending. This was visible with the TTO option, but not with TTO + progress.
image
Now only the date is displayed (not the progress bar).
image

Screenshots (if appropriate):

@Lainow Lainow self-assigned this Jan 30, 2025
@Lainow Lainow requested review from stonebuzz and Rom1-B January 30, 2025 09:24
src/Search.php Outdated
@@ -7107,15 +7107,13 @@ public static function giveItem(
$out = Html::convDateTime($data[$ID][0]['name']);

// No due date in waiting status
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

408061404-f77b1332-20a3-4ba4-94d2-093b9f73b263

In your screenshot, there doesn't seem to be any progression for the waiting status?

That's probably why it was deliberately deactivated, as this comment indicates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the display when status is waiting is the same as when status is closed or resolved
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't that affect TTRs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've corrected the problem.

@Lainow Lainow requested a review from Rom1-B January 30, 2025 10:24
@Rom1-B Rom1-B self-requested a review January 30, 2025 10:36
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we display the TTO here, we should probably also display a progress bar, but with a different color (grey ?) to indicates that the value is not reliable.

Indeed, the waiting time will be added to the TTO when the status of the ticket will change. It mean that the displayed TTO is already stale.

@Lainow
Copy link
Contributor Author

Lainow commented Feb 3, 2025

If we display the TTO here, we should probably also display a progress bar, but with a different color (grey ?) to indicates that the value is not reliable.

Indeed, the waiting time will be added to the TTO when the status of the ticket will change. It mean that the displayed TTO is already stale.

LIke that ?
image

@Lainow Lainow requested a review from cedric-anne February 3, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants