Fix alignment of Email field and Dynamic rowspan #18859
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
previously approved these changes
Feb 5, 2025
cedric-anne
reviewed
Feb 5, 2025
Comment on lines
+3274
to
+3275
| } else { | ||
| echo "<tr class='tab_bg_1'><td colspan='2'></td></tr>"; |
There was a problem hiding this comment.
Result seems to be different depending on the following condition : if ($extauth|| !Session::haveRight("password_update", "1")) {. Indeed the code from line 3267 to 3272 seems to indicate that it may require an additional placeholder.
Could you check ?
cedric-anne
dismissed
their stale review
Not 100% sure of the proposed chnages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
My GLPI instance doesn't support timezones =( So it's not displayed on Simplified UI, only a warning message is shown on Central UI, but as this warning isn't show to the user, it creates an odd situation where the missing Timezone field makes E-mail field overlaps:
This PR fixes this alignment by creating an empty TR (this approach is already taken by other parts of this same PHP function).
It also vertical align the "Emails" field on both UIs.
Before this PR:
Screenshots (if appropriate):