Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of select fields #18871

Open
wants to merge 1 commit into
base: 10.0/bugfixes
Choose a base branch
from

Conversation

eduardomozart
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes # (issue number, if applicable)
  • Here is a brief description of what this PR does

Screenshots (if appropriate):

The select dropdown has been limited to a max width of 270px, but it's container not. It creates a situation where the select has it width limited but not it's container, which makes the buttons (like "i" [info] and "+" [toadd]) not aligned with the fields.

image

After applying this PR it's aligned as expected:

image

This behavior can be seen in Agent task properties page of GLPI Inventory plugin (https://glpi.example.com/plugins/glpiinventory/front/task.form.php?id=1) which uses a fixed width to their selects as seen in https://github.com/glpi-project/glpi-inventory-plugin/blob/c17dbab0b5ed6c8ae8bfb885ca44a40de47e0f34/inc/commonview.class.php#L193-L200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant