Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete button to unassign VLAN from network port #18877

Open
wants to merge 2 commits into
base: 10.0/bugfixes
Choose a base branch
from

Conversation

eduardomozart
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

I was able to reproduce #18845 when trying to remove a VLAN into https://glpi.example.com/front/networkequipment.form.php?id=XXX page so I decided to poke around and fix it. Clicking on the trash icon redirects to a broken page. I couldn't find any references to pass GET parameters and do some action on backend, but noticed that the Massive Actions works, so this passes the same parameters used to unassign a VLAN from port on https://glpi.example.com/front/networkport.form.php?id=XXX.

Screenshots (if appropriate):

Unassign VLAN with this PR applied:

Gravacao.de.Tela.2025-01-31.as.22.21.44.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant