Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum alert delay #18900

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

Rom1-B
Copy link
Contributor

@Rom1-B Rom1-B commented Feb 3, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !36172
  • Here is a brief description of what this PR does

Increase the maximum alert delay from 100 days to the equivalent of 1 year.

As #18770

I tried replacing it with a number input to allow for a higher limit, but due to the inheritance mechanism of this field type, the solution seemed overly complex for its intended purpose. A one-year limit appears to be a good compromise, so I kept the dropdown.

Screenshots (if appropriate):

Example:
image

@trasher trasher merged commit 201b465 into glpi-project:main Feb 4, 2025
9 checks passed
@Rom1-B Rom1-B deleted the support_36172_11 branch February 4, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants