-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typos, make pedantic grammar tweaks, and modify wording #90
base: develop
Are you sure you want to change the base?
Conversation
Thanks @JackElsey . We might hold off on merging this pr until after the upcoming course just to make sure everyone has a consistent notebook version... |
OK, I'll hold off on making more commits until I've worked through more of the tutorials then. |
There are a couple probable equation typos that you may want to be aware of: First, I don't think the variogram formula here should have Second, the Baye's theorem equation here has an unnecessary |
Hey @JackElsey, I have switched this PR over to the |
Changes made include correcting typos (in text and equations), fixing a file reference that didn't work on my system because the file extension was case-sensitive, and a couple edits to improve readability.
If you want to use PEST utilities like TEMPCHEK, there should be instructions for downloading and compiling the PEST source code on macOS and Linux.
5552b11
to
9bcaf5a
Compare
Like tutorial 1_02, this tutorial requires binaries of tempchek, inschek, and pestchek. It did not work on my Linux system until I compiled the PEST source code and added these binaries to the bin_new/linux directory.
ceaca07
to
b815e15
Compare
In this tutorial, the language used to describe sensitivies and elements of the Jacobian matrix used the term "observation" to refer to the model's simulated value corresponding to an observation. I thought this was kind of confusing, so I revised the text and equations. I made similar changes to the description of the Jacobian in Tutorial 0-0.
dedac2b
to
5e8d4e4
Compare
The tutorial said a version 2 PEST control file was created because the model has more than 10k parameters, but the model only has ~6500 parameters. A version 2 PEST control file was created because "version=2" was supplied as an argument to the pyemu.pst.write() method.
The first part of the tutorial uses PESTPP-SWP to complete 250 forward model runs. The second part of the tutorial uses PESPP-IES but was only configured to perform 50 model runs. The text said the second round of MC should take about the same time, so I increased the PEST-IES ensemble count to 250. I also capitalized the names of all PEST++ programs in the tutorial text to match the formatting of the PEST++ manual. I removed a reference in the text saying to look at the terminal window for PEST++ output. In my vanilla installation of Jupyter Lab from Anaconda, all PEST++ output has been appearing in the notebook itself.
No description provided.