Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos, make pedantic grammar tweaks, and modify wording #90

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

JackElsey
Copy link

No description provided.

@jtwhite79
Copy link
Collaborator

Thanks @JackElsey . We might hold off on merging this pr until after the upcoming course just to make sure everyone has a consistent notebook version...

@JackElsey
Copy link
Author

OK, I'll hold off on making more commits until I've worked through more of the tutorials then.

@JackElsey
Copy link
Author

There are a couple probable equation typos that you may want to be aware of:

First, I don't think the variogram formula here should have $h$ in the denominator.

$$\hat{\gamma}\left(h\right)=\frac{1}{2\left(h\right)}\left(z\left(x_1\right)-z\left(x_2\right)\right)^2$$

Second, the Baye's theorem equation here has an unnecessary > in the numerator.

$$P\left(\boldsymbol{\theta}|\textbf{d}\right)=\frac{P\left(\textbf{d}|\boldsymbol{\theta}\right) P\left> (\boldsymbol{\theta}\right)}{P\left(\textbf{d}\right)}$$

@briochh briochh changed the base branch from main to develop September 5, 2023 23:30
@briochh
Copy link
Collaborator

briochh commented Sep 5, 2023

Hey @JackElsey, I have switched this PR over to the develop branch, so we can continue to field contributions without disrupting the main branch till after the course. Feel free to keep pushing to it.

Changes made include correcting typos (in text and equations),
fixing a file reference that didn't work on my system because the
file extension was case-sensitive, and a couple edits to improve
readability.
If you want to use PEST utilities like TEMPCHEK, there should be
instructions for downloading and compiling the PEST source code
on macOS and Linux.
In this tutorial, the language used to describe sensitivies and
elements of the Jacobian matrix used the term "observation" to refer
to the model's simulated value corresponding to an observation. I
thought this was kind of confusing, so I revised the text and
equations. I made similar changes to the description of the Jacobian
in Tutorial 0-0.
The tutorial said a version 2 PEST control file was created
because the model has more than 10k parameters, but the model
only has ~6500 parameters. A version 2 PEST control file was
created because "version=2" was supplied as an argument to the
pyemu.pst.write() method.
The first part of the tutorial uses PESTPP-SWP to complete 250
forward model runs. The second part of the tutorial uses PESPP-IES
but was only configured to perform 50 model runs. The text said
the second round of MC should take about the same time, so I
increased the PEST-IES ensemble count to 250.

I also capitalized the names of all PEST++ programs in the tutorial
text to match the formatting of the PEST++ manual.

I removed a reference in the text saying to look at the terminal
window for PEST++ output. In my vanilla installation of Jupyter
Lab from Anaconda, all PEST++ output has been appearing in the
notebook itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants