fix(gnovm): correct map key persistence

[ltzmaxwell]

update:

closes: #2060 and some other issues, by:

The main issue is that after the pointer value is retrieved from the store, the TV field is not correctly filled, it leads to inconsistent map key calculation. this PR solves this problem.

===========================================================
closes: #2060 and some other issues, by:

- correct map key computation when it's a pointer;
- make key object owned by map value.

The root cause of the issue lies in how the map key is calculated when using a pointer type. Currently, the memory address of the pointer value is used to generate the map key. However, this approach is inconsistent between the VM space and storage space. As a result, if a map key derived from a pointer is persisted and later restored, the two keys do not match.

The proposed solution is to derive an immutable identifier for pointer values. This involves calculating an absolute path for the variables that the pointer value references, ensuring a corresponding and consistent origin.

The absolute path consists of pkgId:blockId:[index], providing a globally unique identifier for the pointer.

For example: In the code below, the map key i, which is a pointer value, has an origin represented as: 15bc39c5756bbda67fd0d56bc9e86b29d7b444fc:1:[1]

// PKGPATH: gno.land/r/ptr_map
package ptr_map

var (
m = map[*int]int{}
i = new(int)
)

func AddToMap(value int) {
m[i] = value
}

func GetFromMap() int {
return m[i]
}

func init() {
*i = 1
AddToMap(5)
}

// ----above is initialized and persisted before main is executed.

func main() {
r := GetFromMap()
println(r == 5)
*i = 2 // this changes TV, also Base of a pointer value
r = GetFromMap()
println(r == 5)
}~~

// Output:
// true
// true

[ltzmaxwell]

another bug identified:

// PKGPATH: gno.land/r/ptr_map
package ptr_map

import "fmt"

type MyStruct struct {
	Name string
}

var (
	m = map[[1]*MyStruct]string{}

	i1   = &MyStruct{Name: "alice"}
	key1 = [1]*MyStruct{i1}
)

func init() {
	m[key1] = "first key"
}

func main() {
	fmt.Println("Value for key1:", m[key1])
}

// Error:
// interface conversion: gnolang.Value is gnolang.RefValue, not *gnolang.ArrayValue

this if fixed.

[ltzmaxwell]

also this, is it counterintuitive?

// PKGPATH: gno.land/r/ptr_map
package ptr_map

type MyStruct struct {
	Name string
}

var (
	m = map[[1]*MyStruct]string{}

	i1 = &MyStruct{Name: "alice"}
)

func main() {
	// Create an array of pointers to MyStruct
	key1 := [1]*MyStruct{i1}
	m[key1] = "first key"
}
// Error:
// unexpected unreal object

this is fixed but should consider the side effects on storage.

XXX, the right way to fix it should me make map key object owned by map.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

[ltzmaxwell]

also this, is it counterintuitive?

// PKGPATH: gno.land/r/ptr_map
package ptr_map

type MyStruct struct {
	Name string
}

var (
	m = map[[1]*MyStruct]string{}

	i1 = &MyStruct{Name: "alice"}
)

func main() {
	// Create an array of pointers to MyStruct
	key1 := [1]*MyStruct{i1}
	m[key1] = "first key"
}
// Error:
// unexpected unreal object

this is fixed but should consider the side effects on storage.

XXX, the right way to fix it should me make map key object owned by map.

This one should be fixed in another scope.

// update:
It's fixed in this PR.

[Gno2D2]

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

• IGNORE the bot requirements for this PR (force green CI check)

Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:

1. Fix any issues flagged by automated checks.
2. Follow the Contributor Checklist to ensure your PR is ready for review.
   • Add new tests, or document why they are unnecessary.
   • Provide clear examples/screenshots, if necessary.
   • Update documentation, if required.
   • Ensure no breaking changes, or include BREAKING CHANGE notes.
   • Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

• Report a bug with the bot.
• View the bot’s configuration file.

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: ltzmaxwell/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

• Any user with comment edit permission

[thehowl]

Still not fully clear, but I'm very tired, so will continue when I can

[ltzmaxwell]

working on an alternative solution, make this draft now.

[ltzmaxwell]

the previous solution was based on an incorrect assumption. The current solution is more accurate. could you please review it again? 🙏 @thehowl @mvertes