refactor: `r/demo/users` #3166

leohhhn · 2024-11-20T11:26:05Z

Description

Addresses: #2827

This PR refactors the current r/demo/users & r/sys/users system in accordance to the issue mentioned above. Below is the high-level overview of the new system.

It also makes a small change to the p/demo/releases lib.

`r/gnoland/users/v1`

Fully replaces r/demo/users
Is the main entry point for users looking to register a name, create an alias (rename themselves), or delete their username
Implements allowed username pattern checks as per the issue r/sys/users Mainnet v1 (mvp) & v2 #2827
Is pausable by GovDAO, contains no other administration functionality
Contains a nice UI/render for users (please suggest improvements) - see bottom
Uses r/demo/profile for displaying extra information about a user

`r/sys/users`

Namespace check moved to r/sys/names
Contains the address/name <> user stores, to which only whitelisted realms can write
Contains resolver functions & other useful getters
Is callable only by whitelisted realms, such as r/gnoland/users/v1, etc. Whitelist is managed by an ownable object
Is ownable+pausable until chore: remove govdao dependency in r/gov/dao/bridge #3523 is resolved so that GovDAO can be the sole owner of the realm, and can manage the whitelist & pausability

`r/sys/names`

Namespace checking functionality moved here (from r/sys/users), added tests, as discussed with @moul
Verify function now only upgradeable with a GovDAO prop instead of previously being ownable
Verify functionality is now not pausable and on by default, as per discussions with @moul. This means Portal Loop will need to be patched upon merging this PR, as many txs will fail due to not having proper namespace permissions.

`Keeper` & genesis params

Updated the VM keeper to call r/sys/names for the namespace check instead of r/sys/users
Updated params to load r/sys/names, which the keeper will call

`r/gnoland/users/v1`

`r/gnoland/users`

Currently this is the "releases" page for the user registration systems (example data):

Contributors' checklist...

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests

codecov · 2024-11-21T05:45:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

# Conflicts: # examples/gno.land/r/demo/users/users.gno # examples/gno.land/r/demo/users/z_10_filetest.gno # examples/gno.land/r/demo/users/z_11_filetest.gno # examples/gno.land/r/demo/users/z_11b_filetest.gno # examples/gno.land/r/demo/users/z_2_filetest.gno # examples/gno.land/r/demo/users/z_3_filetest.gno # examples/gno.land/r/demo/users/z_4_filetest.gno # examples/gno.land/r/demo/users/z_5_filetest.gno # examples/gno.land/r/demo/users/z_6_filetest.gno # examples/gno.land/r/demo/users/z_7_filetest.gno # examples/gno.land/r/demo/users/z_7b_filetest.gno # examples/gno.land/r/demo/users/z_8_filetest.gno # examples/gno.land/r/demo/users/z_9_filetest.gno # examples/gno.land/r/sys/users/verify.gno

examples/gno.land/p/demo/pausable/pausable.gno

ajnavarro

AFAIK, everything looks good. Someone in charge of the needed business logic here must also review this.

leohhhn · 2025-01-27T15:18:54Z

Docs lint will be green once PR is merged, as the links that are broken are created in this PR

examples/gno.land/r/demo/groups/misc.gno

examples/gno.land/r/demo/boards/misc.gno

docs/gno-tooling/cli/gnokey/querying-a-network.md

docs/reference/stdlibs/std/testing.md

examples/gno.land/r/gnoland/home/home.gno

gno.land/pkg/integration/testdata/issue_2283.txtar

gno.land/pkg/gnoweb/app_test.go

gno.land/genesis/genesis_txs.jsonl

Co-authored-by: Manfred Touron <[email protected]>

update user rendering

38c2b9a

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Nov 20, 2024

github-actions bot assigned leohhhn Nov 20, 2024

leohhhn and others added 2 commits November 20, 2024 21:20

save

4970a59

Merge branch 'master' into refac/users

833576b

register

2c4f497

zivkovicmilos self-requested a review November 21, 2024 06:03

leohhhn and others added 8 commits November 21, 2024 17:54

Merge branch 'master' into refac/users

6f9b787

add gnoland/users, expand sys/users

74d6ae7

add resolving

487775b

pausable to sys/users

25c3fa1

update regex & add godoc

d06515e

update regex & add godoc

905bc10

save

970b3f0

save

0ad5292

leohhhn changed the title ~~refactor: r/demo/users~~ refactor: r/demo/users Nov 21, 2024

leohhhn and others added 7 commits November 22, 2024 00:51

fix err name

3d72544

Merge branch 'master' into refac/users

2f68087

Merge branch 'master' into refac/users

114de1b

add paginated fetch

a3ed4e6

add list by prefix

b7cc608

fix imports

3e58017

add admin tests

69cfe1c

github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Nov 25, 2024

leohhhn force-pushed the refac/users branch from e70920e to 69cfe1c Compare November 26, 2024 11:04

leohhhn added 2 commits November 26, 2024 12:05

fix

46fcc93

leohhhn and others added 4 commits January 27, 2025 11:49

update test

ec8f58a

bump gas on tst

91723df

Merge branch 'master' into refac/users

3785d16

remove wal

3dd585d

Kouteki added this to the 🚀 Mainnet beta launch milestone Jan 27, 2025

ajnavarro reviewed Jan 27, 2025

View reviewed changes

examples/gno.land/p/demo/pausable/pausable.gno Show resolved Hide resolved

ajnavarro approved these changes Jan 27, 2025

View reviewed changes

update docs

05a9f9a