Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: addressability #3198

Merged
merged 46 commits into from
Jan 20, 2025
Merged

fix: addressability #3198

merged 46 commits into from
Jan 20, 2025

Conversation

petar-dambovaliev
Copy link
Contributor

@petar-dambovaliev petar-dambovaliev commented Nov 26, 2024 •
edited
Loading

Fixes #2299 and #2840

deelawn and others added 30 commits November 26, 2024 15:30
@deelawn @petar-dambovaliev
preprocessor addressability work
7c4e8e3
@deelawn @petar-dambovaliev
fix selector isaddressable
7410b72
@deelawn @petar-dambovaliev
fix starexpr isaddressable
4f771bd
@deelawn @petar-dambovaliev
fix sliceexpr addressability
45834d1
@deelawn @petar-dambovaliev
fix typeassertexpr addressability
aafff5d
@deelawn @petar-dambovaliev
fix callexpr addressable return types
79f62e9
@deelawn @petar-dambovaliev
mark append and new results as addressable
94bb0b1
@deelawn @petar-dambovaliev
fix selector addressability
cce27cd
@deelawn @petar-dambovaliev
make string indexes non-addressable
8ea7834
@deelawn @petar-dambovaliev
addressability file tests
ab278ac
@deelawn @petar-dambovaliev
prohibit taking address of imported typed constant
7fe5f7d
@deelawn @petar-dambovaliev
more tests
b2324ec
@deelawn @petar-dambovaliev
fix type assertion addressability and add tests
42fc0a7
@deelawn @petar-dambovaliev
make sure to use base types when considering addressability
6482090
@deelawn @petar-dambovaliev
move tests
6a33287
@deelawn @petar-dambovaliev
fix index and selector addressability
46e4ab4
@deelawn @petar-dambovaliev
introduce concept of addressability not applicable
a2c1f8f
@deelawn @petar-dambovaliev
fixed test
45cc996
@deelawn @petar-dambovaliev
fixed test
c319b9a
@deelawn @petar-dambovaliev
fix test
4d33cd7
@deelawn @petar-dambovaliev
func lit tests
390a60e
@deelawn @petar-dambovaliev
index, map, and call expr fixes and tests
b0b4b1e
@deelawn @petar-dambovaliev
addressability consistentcy fixes
5168d86
@deelawn @petar-dambovaliev
consolidate simplest block path traversal
ff09bee
@deelawn @petar-dambovaliev
fix comment
7473087
@deelawn @petar-dambovaliev
Removed test and renamed other
f9da3e7
@petar-dambovaliev
move and rename addressability constants
ed3c86e
@deelawn @petar-dambovaliev
remove assertExpr
290fa28
@deelawn @petar-dambovaliev
clarifying comment
9c381d4
@deelawn @petar-dambovaliev
fixed comment
49cb94c
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Nov 26, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.44295% with 50 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/nodes.go 51.51% 42 Missing and 6 partials ⚠️
gnovm/pkg/gnolang/preprocess.go 96.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@petar-dambovaliev petar-dambovaliev mentioned this pull request Nov 26, 2024
Open
7 tasks
@petar-dambovaliev petar-dambovaliev changed the title Fix: addressability fix: addressability Nov 26, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Nov 27, 2024
ltzmaxwell
ltzmaxwell requested changes Dec 9, 2024
View reviewed changes
gnovm/tests/files/addressable_1b_err.gno Show resolved Hide resolved
gnovm/pkg/gnolang/nodes.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/nodes.go Show resolved Hide resolved
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 9, 2024 •
edited
Loading

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@petar-dambovaliev petar-dambovaliev enabled auto-merge (squash) January 20, 2025 14:58
@petar-dambovaliev
Copy link
Contributor Author

petar-dambovaliev commented Jan 20, 2025 •
edited
Loading

This is done. The test that is failing seems to be introduced by master having broke something. @ltzmaxwell

ltzmaxwell
ltzmaxwell approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ltzmaxwell ltzmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@petar-dambovaliev petar-dambovaliev merged commit fc40183 into master Jan 20, 2025
48 of 49 checks passed
@petar-dambovaliev petar-dambovaliev deleted the fix/addressability branch January 20, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltzmaxwell ltzmaxwell ltzmaxwell approved these changes

@mvertes mvertes Awaiting requested review from mvertes

@notJoon notJoon Awaiting requested review from notJoon

Assignees

@petar-dambovaliev petar-dambovaliev

Labels
📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
🧙‍♂️gno.land core team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug/gnovm] arrays returned by functions should not be addressable
5 participants
@petar-dambovaliev @Gno2D2 @ltzmaxwell @Kouteki @deelawn