Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add genesis packages with transaction signing #3280

Merged

Conversation

Villaquiranm
Copy link
Contributor

closes #1104

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Dec 5, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 5, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: Villaquiranm/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 80.43478% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gno.land/pkg/integration/signer.go 64.70% 4 Missing and 2 partials ⚠️
gno.land/pkg/integration/pkgloader.go 50.00% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@zivkovicmilos zivkovicmilos self-requested a review December 6, 2024 14:50
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Dec 9, 2024
@Gno2D2 Gno2D2 requested review from a team December 9, 2024 18:26
@Villaquiranm Villaquiranm marked this pull request as ready for review December 19, 2024 15:53
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Dec 20, 2024
@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone Dec 20, 2024
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good 💯

I've left some improvement comments, and we should be good to go 🙏

contribs/gnogenesis/internal/txs/txs_add_packages.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages_test.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages_test.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages_test.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages_test.go Outdated Show resolved Hide resolved
@Villaquiranm Villaquiranm force-pushed the feat/sign-transactions-genesis branch from 1c49150 to e33600f Compare January 7, 2025 21:21
contribs/gnogenesis/internal/txs/txs_add_packages.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages_test.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages_test.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages_test.go Outdated Show resolved Hide resolved
gno.land/pkg/integration/defaultsigner.go Outdated Show resolved Hide resolved
gno.land/pkg/integration/defaultsigner.go Outdated Show resolved Hide resolved
gno.land/pkg/integration/defaultsigner.go Outdated Show resolved Hide resolved
gno.land/pkg/integration/defaultsigner.go Outdated Show resolved Hide resolved
@zivkovicmilos zivkovicmilos merged commit ac30689 into gnolang:master Jan 9, 2025
104 checks passed
@Villaquiranm Villaquiranm deleted the feat/sign-transactions-genesis branch January 9, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in focus Core team is prioritizing this work 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

Reminder: need to set VerifyGenesisSignatures to true on mainnet,
5 participants