Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlibs/std)!: replace IsOriginCall with PrevRealm().IsUser() for EOA checks #3399

Merged
merged 15 commits into from
Feb 4, 2025

Conversation

omarsy
Copy link
Member

@omarsy omarsy commented Dec 21, 2024

Linked to #1475

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Dec 21, 2024
@Gno2D2 Gno2D2 requested review from a team December 21, 2024 12:18
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 21, 2024

🛠 PR Checks Summary

🔴 Must not contain the "don't merge" label

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check) (checked by @zivkovicmilos)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff
🔴 Must not contain the "don't merge" label
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: omarsy/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

If

🟢 Condition met
└── 🟢 A changed file matches this pattern: ^docs/ (filename: docs/reference/stdlibs/std/chain.md)

Then

🟢 Requirement satisfied
└── 🟢 And
    ├── 🟢 Or
    │   ├── 🔴 Pull request author is a member of the team: tech-staff
    │   └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request(with state "APPROVED")
    └── 🟢 Or
        ├── 🔴 Pull request author is a member of the team: devrels
        └── 🟢 At least 1 user(s) of the team devrels reviewed pull request(with state "APPROVED")

Must not contain the "don't merge" label

If

🟢 Condition met
└── 🟢 A label matches this pattern: don't merge (label: don't merge)

Then

🔴 Requirement not satisfied
└── 🔴 On no pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@omarsy omarsy force-pushed the feat/remove-is-origin-call branch from b4d2e9f to 9c5b56b Compare December 22, 2024 23:27
@omarsy omarsy changed the title refactor(std): replace IsOriginCall with PrevRealm().IsUser() for EOA… refactor(std): replace IsOriginCall with PrevRealm().IsUser() for EOA checks Dec 23, 2024
@omarsy omarsy marked this pull request as ready for review December 26, 2024 20:49
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Dec 26, 2024
@notJoon notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 30, 2024
@Kouteki Kouteki removed the request for review from a team January 6, 2025 12:54
@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone Jan 6, 2025
@Kouteki Kouteki requested review from thehowl, mvertes, ltzmaxwell and petar-dambovaliev and removed request for a team January 7, 2025 18:06
@Gno2D2 Gno2D2 requested review from a team January 7, 2025 18:07
@zivkovicmilos zivkovicmilos added the don't merge Please don't merge this functionality temporarily label Jan 8, 2025
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find anything out of place, so looks alright 💯

Please wait for me to coordinate this change on the PL 🙏

@Gno2D2 Gno2D2 requested a review from a team January 8, 2025 09:32
@omarsy omarsy force-pushed the feat/remove-is-origin-call branch from 8fb3cc6 to d55c5a0 Compare January 18, 2025 21:58
@Gno2D2 Gno2D2 requested a review from a team January 19, 2025 22:04
@omarsy omarsy force-pushed the feat/remove-is-origin-call branch 3 times, most recently from d0479e9 to 602f2be Compare January 20, 2025 22:12
@omarsy omarsy force-pushed the feat/remove-is-origin-call branch from 602f2be to 5d1c3e8 Compare January 20, 2025 22:45
@Gno2D2 Gno2D2 requested a review from a team January 21, 2025 12:33
@thehowl thehowl changed the title refactor(std): replace IsOriginCall with PrevRealm().IsUser() for EOA checks feat(stdlibs/std)!: replace IsOriginCall with PrevRealm().IsUser() for EOA checks Jan 21, 2025
@Kouteki Kouteki removed the in focus label Feb 3, 2025
@Gno2D2 Gno2D2 requested review from a team February 3, 2025 09:23
@zivkovicmilos zivkovicmilos removed the don't merge Please don't merge this functionality temporarily label Feb 4, 2025
@zivkovicmilos zivkovicmilos merged commit 85a8740 into gnolang:master Feb 4, 2025
70 of 71 checks passed
petar-dambovaliev pushed a commit that referenced this pull request Feb 4, 2025
…` for EOA checks (#3399)

Linked to #1475

---------

Co-authored-by: Morgan Bazalgette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

7 participants