feat: add JJOptimist's Homepage realm to examples #3405

JJOptimist · 2024-12-25T12:05:16Z

This pull request adds a new realm example to the Gno examples repository—JJOptimist's Homepage.

The realm includes:

Personal introduction and contact information
Configuration management system
Owner controls
Tests for ownership and rendering

Gno2D2 · 2024-12-25T12:06:21Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)
The pull request description provides enough details

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: JJOptimist/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission
The pull request description provides enough details
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])
Can be checked by

team core-contributors

leohhhn

Please check comments 🙏

Apart from that, if you want to merge something into the examples/ folder, it should provide some educational value about Gno to newcomers. Please, explore a bit more and see what interesting realms or packages you can use to make your home realm more unique, so that it can be merged into the monorepo.

If you do not want to do this, you can simply deploy persmissionlessly.

examples/gno.land/r/jjoptimist/config.gno

examples/gno.land/r/jjoptimist/home_test.gno

leohhhn · 2025-01-09T20:45:51Z

Hey @JJOptimist, what's the status of this PR?

JJOptimist · 2025-01-09T23:50:50Z

Hey @JJOptimist, what's the status of this PR?

I fixed the things you pointed out and took your suggestion to use ownable. Ive been experimenting to make something creative/ worth the HoF, so i will push it all together soon

JJOptimist · 2025-01-10T15:31:05Z

I've updated the realm

Integrated p/demo/ownable for proper ownership management and access control
Added dynamic ASCII art gnome that changes based on block height
Moved files to home/ directory structure
Added proper tests for both ownership and configuration

The gnome's expression changes based on block height divisibility (by 2, 3, 5, or 7)

jefft0 · 2025-01-10T15:33:37Z

mykey_backup.armor

Should this file be removed?

Thanks for quick notice, removed it

mykey_backup.armor

leohhhn · 2025-01-10T15:37:35Z

@JJOptimist

Generally, please take a look at comments and reply to them, even if they're outdated because you've changed the code completely.

JJOptimist · 2025-01-13T11:11:49Z

Thanks for your patience. Let me explain the code evolution:

Initially, I tried to create an animated realm with CSS animations. However, I discovered that complex CSS animations weren't the best approach for a Gno realm, as:

CSS animations added unnecessary complexity
The focus should be on demonstrating Gno-specific features
Markdown rendering is more reliable for realm display

leohhhn

Good start; please fix the things I mentioned in the comments below :)

examples/gno.land/r/jjoptimist/home/home_test.gno

examples/gno.land/r/jjoptimist/home/home.gno

examples/gno.land/r/jjoptimist/home/gno.mod

examples/gno.land/r/jjoptimist/home/config.gno

examples/gno.land/r/jjoptimist/home/home.gno

examples/gno.land/r/jjoptimist/home/config.gno

examples/gno.land/r/jjoptimist/home/home.gno

JJOptimist · 2025-01-19T15:51:21Z

I've updated the home realm:

Changed gnome art variables to constants for better code organization
Replaced if-else chain with switch statement for cleaner gnome art selection
Properly defined Config struct with exported fields for better type safety
Exported Ownable and implemented AssertCallerIsOwner for proper access control
Removed redundant GetOwner() function since Ownable is now exported
Changed require to dependencies in gno.mod following new standards
Properly spaced out imports for better readability
Registered realm in Hall of Fame for community visibility
Removed ownership tests to avoid testing imported package functionality
Using direct config access in same package for better efficiency

examples/gno.land/r/jjoptimist/home/config.gno

examples/gno.land/r/jjoptimist/home/home.gno

leohhhn · 2025-01-21T10:12:02Z

examples/gno.land/r/jjoptimist/home/home.gno

+func getGnomeArt(height int64) string {
+    var art string
+    switch {
+    case height%7 == 0:
+        art = gnomeArt4  // winking gnome
+    case height%5 == 0:
+        art = gnomeArt3  // starry-eyed gnome
+    case height%3 == 0:
+        art = gnomeArt2  // happy gnome
+    default:
+        art = gnomeArt1  // regular gnome
+    }
+    return "```\n" + art + "\n```\n"
+}


Move this to the bottom or somewhere else, since this is a helper function

Co-authored-by: Leon Hudak <[email protected]>

codecov · 2025-01-22T12:03:57Z

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
tm2/pkg/overflow/overflow_impl.go	50.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

leohhhn

Just check the leftover comments, and run make fmt in examples :)

examples/gno.land/r/jjoptimist/home/config.gno

leohhhn · 2025-01-28T22:05:55Z

examples/gno.land/r/jjoptimist/home/home.gno

+    "strconv"
+    "time"
+
+    "gno.land/p/demo/ownable"


This is unused

Co-authored-by: Leon Hudak <[email protected]>

feat: add JJOptimist's Homerealm

f76c480

github-actions bot assigned JJOptimist Dec 25, 2024

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 25, 2024

notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 26, 2024

leohhhn self-requested a review December 27, 2024 04:31

leohhhn requested changes Dec 27, 2024

View reviewed changes

Merge branch 'gnolang:master' into master

b755bc7

feat: added usage of ownable and art

d7fec48

jefft0 reviewed Jan 10, 2025

View reviewed changes

leohhhn reviewed Jan 10, 2025

View reviewed changes

mykey_backup.armor Outdated Show resolved Hide resolved

chore: remove mykey_backup.armor

6746b48

Merge branch 'master' into master

c6f2243

leohhhn requested changes Jan 14, 2025

View reviewed changes

leohhhn reviewed Jan 14, 2025

View reviewed changes

examples/gno.land/r/jjoptimist/home/home.gno Outdated Show resolved Hide resolved

JJOptimist added 2 commits January 19, 2025 16:46

fix: update based on feedback and registered in HoF

26141d3

Merge branch 'master' of https://github.com/JJOptimist/gno

ae762a4

JJOptimist and others added 3 commits January 19, 2025 17:23

Merge branch 'master' into master

771ebb2

fix: clean dependencies

4de53c4

Merge branch 'master' of https://github.com/JJOptimist/gno

21cd795

leohhhn reviewed Jan 21, 2025

View reviewed changes

examples/gno.land/r/jjoptimist/home/config.gno Outdated Show resolved Hide resolved

leohhhn reviewed Jan 21, 2025

View reviewed changes

examples/gno.land/r/jjoptimist/home/home.gno Outdated Show resolved Hide resolved

leohhhn reviewed Jan 21, 2025

View reviewed changes

fix: path fix in gno.mod

b7f16d4

JJOptimist and others added 3 commits January 21, 2025 11:46

Update examples/gno.land/r/jjoptimist/home/config.gno

faba174

Co-authored-by: Leon Hudak <[email protected]>

Update examples/gno.land/r/jjoptimist/home/home.gno

99a6ff4

Co-authored-by: Leon Hudak <[email protected]>

Merge branch 'master' into master

7a338dc

github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related labels Jan 21, 2025

JJOptimist force-pushed the master branch from 4ae4d0d to 7a338dc Compare January 26, 2025 16:32

Gno2D2 requested a review from a team January 26, 2025 16:34

Merge branch 'master' into master

5988bd2

leohhhn approved these changes Jan 28, 2025

View reviewed changes

Update examples/gno.land/r/jjoptimist/home/config.gno

b30c106

Co-authored-by: Leon Hudak <[email protected]>

Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 28, 2025

JJOptimist added 3 commits January 28, 2025 23:28

fix(home): removed unused import

d674a91

Merge branch 'master' of https://github.com/JJOptimist/gno

4b63d70

chore: fix fmt

51e795c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add JJOptimist's Homepage realm to examples #3405

feat: add JJOptimist's Homepage realm to examples #3405

JJOptimist commented Dec 25, 2024

Gno2D2 commented Dec 25, 2024 •

edited

Loading

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

If

Can be checked by

leohhhn left a comment

leohhhn commented Jan 9, 2025

JJOptimist commented Jan 9, 2025

JJOptimist commented Jan 10, 2025

jefft0 Jan 10, 2025

JJOptimist Jan 10, 2025

leohhhn commented Jan 10, 2025

JJOptimist commented Jan 13, 2025

leohhhn left a comment

JJOptimist commented Jan 19, 2025

leohhhn Jan 21, 2025

codecov bot commented Jan 22, 2025

leohhhn left a comment

leohhhn Jan 28, 2025

feat: add JJOptimist's Homepage realm to examples #3405

Are you sure you want to change the base?

feat: add JJOptimist's Homepage realm to examples #3405

Conversation

JJOptimist commented Dec 25, 2024

Gno2D2 commented Dec 25, 2024 • edited Loading

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

If

Can be checked by

leohhhn left a comment

Choose a reason for hiding this comment

leohhhn commented Jan 9, 2025

JJOptimist commented Jan 9, 2025

JJOptimist commented Jan 10, 2025

jefft0 Jan 10, 2025

Choose a reason for hiding this comment

JJOptimist Jan 10, 2025

Choose a reason for hiding this comment

leohhhn commented Jan 10, 2025

JJOptimist commented Jan 13, 2025

leohhhn left a comment

Choose a reason for hiding this comment

JJOptimist commented Jan 19, 2025

leohhhn Jan 21, 2025

Choose a reason for hiding this comment

codecov bot commented Jan 22, 2025

Codecov Report

leohhhn left a comment

Choose a reason for hiding this comment

leohhhn Jan 28, 2025

Choose a reason for hiding this comment

Gno2D2 commented Dec 25, 2024 •

edited

Loading