-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cmd): gno mod
module name validations
#3526
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
@notJoon , can you resolve the CI check for "gno.land / Run gno.land suite / Go Test" ? |
@jefft0 Thanks for notifying me. Now all issues have been resolved except for the review-triage stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR appears to correctly address and resolve issue #3493 . A test is included. All CI checks pass (except "Merge Requirements" which will be resolved later).
Removed the |
Description
Added module path validation to prevent invalid characters from being written to
gno mod
initialization.The validation:
Implementation Details
validateModulePath
function with comprehensive validation rulesexecModInit
Added Tests
TestValidateModulePath
: Tests various validation scenarios includingTestExecModInit
: Integration tests coveringRelative Issue
closes #3493