-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tm2/pkg/bft,os,p2p): close leaking resources #3556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
thehowl
reviewed
Jan 20, 2025
odeke-em
force-pushed
the
tm-close-leaking-files
branch
from
January 20, 2025 11:36
f046d7c
to
18e167c
Compare
This change closes some leaking resources that were identified in a preliminary code read. Fixes gnolang#3029 Fixes gnolang#3030 Fixes gnolang#3031
odeke-em
force-pushed
the
tm-close-leaking-files
branch
from
January 20, 2025 11:52
18e167c
to
57dabb1
Compare
odeke-em
changed the title
fix((tm2/pkg/bft,os,p2p): close leaking resources
fix(tm2/pkg/bft,os,p2p): close leaking resources
Jan 20, 2025
thehowl
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change closes some leaking resources that were identified in a preliminary code read.
Fixes #3029
Fixes #3030
Fixes #3031