Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tm2/pkg/bft,os,p2p): close leaking resources #3556

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

odeke-em
Copy link
Contributor

This change closes some leaking resources that were identified in a preliminary code read.

Fixes #3029
Fixes #3030
Fixes #3031

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jan 20, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 20, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details (checked by @thehowl)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: odeke-em/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tm2/pkg/bft/privval/utils.go 40.00% 2 Missing and 1 partial ⚠️
tm2/pkg/p2p/transport.go 40.00% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

tm2/pkg/bft/privval/utils.go Show resolved Hide resolved
tm2/pkg/os/tempfile.go Outdated Show resolved Hide resolved
tm2/pkg/p2p/transport.go Show resolved Hide resolved
@odeke-em odeke-em force-pushed the tm-close-leaking-files branch from f046d7c to 18e167c Compare January 20, 2025 11:36
This change closes some leaking resources that were identified
in a preliminary code read.

Fixes gnolang#3029
Fixes gnolang#3030
Fixes gnolang#3031
@odeke-em odeke-em force-pushed the tm-close-leaking-files branch from 18e167c to 57dabb1 Compare January 20, 2025 11:52
@odeke-em odeke-em requested a review from thehowl January 20, 2025 11:55
@odeke-em odeke-em changed the title fix((tm2/pkg/bft,os,p2p): close leaking resources fix(tm2/pkg/bft,os,p2p): close leaking resources Jan 20, 2025
@thehowl thehowl merged commit 09764ad into gnolang:master Jan 20, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment