wip: implements r/sys/teams
#3568
Conversation
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
github-actions
bot
added
🧾 package/realm
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Signed-off-by: gfanton <[email protected]>
|
|
||
| // Check if caller is not already registered as a team | ||
| if teams.Has(caller.String()) { | ||
| panic("team already registered: " + caller.String()) |
There was a problem hiding this comment.
it's okay to have this condition, but then we need a Replace(newTeam ITeam) companion func.
| // ITeam combines the AccessController and Lifecycle interfaces to define a complete | ||
| // team interface. It ensures that a team has both access control and lifecycle | ||
| // management capabilities. | ||
| type ITeam interface { |
There was a problem hiding this comment.
need another name, because of the type Team struct which isn't related.
|
|
||
| // reHomeRealm validate thehome realm path format `xxx.xx/r/<myteam>/home`. | ||
| // XXX: Use somthing simpler | ||
| var reHomeRealm = regexp.MustCompile(`^([a-zA-Z0-9-]+\.)*[a-zA-Z0-9-]+\.[a-zA-Z]{2,}/r/[a-z0-9_]+/home$`) |
There was a problem hiding this comment.
FYI, I'm not opposed to reimplementing the logic in this area, but take a look at this library: https://github.com/gnolang/gno/blob/master/examples/gno.land/p/moul/realmpath/realmpath.gno.
I believe that ensuring full security also requires verifying that the domain is from the same chain due to IBC.
| Lifecycle: iteam, | ||
| AccessController: iteam, |
There was a problem hiding this comment.
really looks like a single interface would be better.
There was a problem hiding this comment.
Yea, I wanted some modularity and a straightforward way to update the access controller without touching the lifecycle part. However, upon further reflection, I think you right, enforcing the whole ITeam update is simpler for both implementation and the client. I will merge this into a single interface.
| AccessController: iteam, | ||
| } | ||
| // Assert that team implementation correctly uses fallback | ||
| // XXX: do we want this? |
There was a problem hiding this comment.
No, we don't want this. However, it's acceptable to have it if creating a "Noop" command is straightforward. Consider that you need to define an interface that accommodates most of your workflows. Additionally, some teams may prefer to remain static, with no option for updates.
There was a problem hiding this comment.
I need to read it again later today if possible. However, I think the direction looks good, but it mixes independent topics that should exist separately:
- The
r/sys/teamsregistration system, which is primarily a smart map of interfaces. - The
{p,r}/guigui/generic_team, an opinionated framework for managing teams that is compatible withr/sys/teams.
I also believe that due to the upcoming inter-realm ownership constraints and our desire for the /home to be an upgradeable contract (not importable and unable to store local items on other realms), we will need a standalone registry.
In summary, I anticipate two main usages:
func init() { teams.ConfigureWithPrimitiveTypes(std.Address, string, bool) }registers or overrides using only primitive types that can be stored byr/sys/teams. This approach should provide very simple team support without the ability to "add" members, as the only way to do so is by calling "Configure" repeatedly.team := teamregistry.New(guiguiteam.New()); teams.RegisterInstance(team)
WIP
Address #2195
This PR introduces a potential implementation of the
r/sys/teamspackage for managing team memberships and permissions through an access-controlled lifecycle management system. The package uses encapsulated tasks to handle state updates, ensuring both permission and flexibility in team operations.Currently, the implementation needs more fine-tuning, but the core idea is present.
TODO:
Signed-off-by: gfanton [email protected]