Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gnoweb): improve layouts and reduce code duplication #3569

Merged
merged 29 commits into from
Jan 22, 2025

Conversation

alexiscolin
Copy link
Member

This PR aims to improve the HTML composability of gnoweb and avoid DRY issues across templates and layouts. The changes include:

  • Refactoring HTML components for better reusability.
  • Reducing code duplication in views.
  • Removing static data from the layout
  • Enhancing code maintainability and readability.

@alexiscolin alexiscolin requested a review from gfanton January 21, 2025 09:20
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jan 21, 2025
@alexiscolin alexiscolin added the 🌍 gnoweb Issues & PRs related to gnoweb and render label Jan 21, 2025
@alexiscolin alexiscolin marked this pull request as draft January 21, 2025 09:20
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 21, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member (and label matches review triage state)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: alexiscolin/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member (and label matches review triage state)

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization approved the pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@alexiscolin alexiscolin changed the title refacto(gnoweb): improve layouts and reduce code duplication refactor(gnoweb): improve layouts and reduce code duplication Jan 21, 2025
@alexiscolin alexiscolin marked this pull request as ready for review January 22, 2025 06:12
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 22, 2025
Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 22, 2025
@gfanton gfanton merged commit 2ec6a15 into gnolang:master Jan 22, 2025
53 checks passed
stefann-01 pushed a commit to stefann-01/gno that referenced this pull request Jan 24, 2025
…g#3569)

This PR aims to improve the HTML composability of gnoweb and avoid DRY
issues across templates and layouts. The changes include:

- Refactoring HTML components for better reusability.
- Reducing code duplication in views.
- Removing static data from the layout
- Enhancing code maintainability and readability.

---------

Signed-off-by: gfanton <[email protected]>
Co-authored-by: gfanton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌍 gnoweb Issues & PRs related to gnoweb and render 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Development

Successfully merging this pull request may close these issues.

4 participants