-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pipeline): run build of github pages on pullRequests #3607
base: master
Are you sure you want to change the base?
chore(pipeline): run build of github pages on pullRequests #3607
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
stdlibs_diff is a tool that generates an html report indicating differences between gno standard libraries and go standrad libraries | ||
stdlibs_diff is a tool that generates an html report indicating differences between gno standard libraries and go standard libraries. | ||
|
||
⚠️ When using goenv to set the src or the destination, the Go version will be the one from the toolchain on go.mod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this comment makes sense, especially as a warning. Isn't it the concept of goenv?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello thanks for your review, maybe It will do more sense as a comment on the gh-pages.yml?
The idea was to mention what Golang version is used for the stdlibs comparaison. This was a need from the issue
closes #3572