feat: refactor handletransfer to use handlerwithloader and not load entities on handler #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this one still relevant? you mentioned that it didn't change performances? |
teawaterwire
reviewed
Jan 7, 2025
| async ({ event, context }) => | ||
| await handleTransfer({ | ||
| PersonalCRC.Transfer.handlerWithLoader({ | ||
| loader: async ({ event, context }) => { |
There was a problem hiding this comment.
interesting that we didn't have this code elsewhere before?
There was a problem hiding this comment.
which code? The Token and AvatarBalance were loaded in the handleTransfer method.
teawaterwire
reviewed
Jan 7, 2025
| avatar_id: event.params.to, | ||
| token_id: tokenId, | ||
| }, | ||
| from: allAvatarBalances[i * 2 + 1] ?? { |
There was a problem hiding this comment.
because i needs AvatarBalance "from" user and "to" user. Given that they are all in one single array, then it jumps each two entities
0-1
2-3
...
maybe i should ask envio team. I'm surprised with the results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.