adding v2 to go.mod #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Fixing go.mod
Which issue(s) does this PR fix/relate to?
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
example_test.goREADME.mdNotes
@JohnRoesler it seems that since I did not update go.mod to add
/v2to the module name, people can't download the dependency. In this PR I added the v2. But I am afraid I messed it up with the branching, since, in theory, master should have continued with the v1, and I should have created a v2 branch for the v2 of the locker.To be honest I don't think I need to keep supporting v1, so, if possible, I would like that the master branch now points only to the v2. But what do you think? shall we try to make master -> v2, or shall we follow the approach of master -> v1, and v2 -> v2.