Forcibly replace github.com/satori/go.uuid

[zeripath]

There are several dependencies which still reference github.com/satori/go-uuid despite
the long recognised problem with this library.

This PR proposes replacing satori/go.uuid with my recently created fork which is shim
against google/uuid. This shim is not a perfect replacement for satori as it misses
several functions available on the old type - however, these should only be rarely used
in any case and certainly testing appears to imply that these functions are not used.

Close #18311

Signed-off-by: Andrew Thornton [email protected]

[KN4CK3R]

satori/go.uuid#115 mentioned https://github.com/gofrs/uuid as replacement. Could we use that instead?

[zeripath]

Which version of go-frs do you propose to use?

[KN4CK3R]

I have not looked into it but as it has the same api surface so it should be a drop in replacement. If maintaining your shim is not a problem we can use yours.

[zeripath]

If you're going to suggest a different library - please do the work to check and figure out which one.

One problem with not using the shim as above is that you won't then be able to forcibly update the version of go-frs using the replace notation. (I think)

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@d7c2a29). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #18282   +/-   ##
=======================================
  Coverage        ?   45.74%           
=======================================
  Files           ?      831           
  Lines           ?    92165           
  Branches        ?        0           
=======================================
  Hits            ?    42162           
  Misses          ?    43244           
  Partials        ?     6759           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c2a29...7d81ca0. Read the comment docs.

[6543]

satori/go.uuid#115 mentioned https://github.com/gofrs/uuid as replacement. Could we use that instead?

looked at this lib too, i fafour googl/uuid

[noerw]

what do you think of hosting such gitea-related/maintained shims & forks on gitea.com?

[zeripath]

what do you think of hosting such gitea-related/maintained shims & forks on gitea.com?

Happy to move these to gitea.com if preferred.

I think we could even consider hosting them on the system.

looked at this lib too, i fafour googl/uuid

Unfortunately we can't force the go-frs/uuid code to use the same shim we'd have to create another one.

---

I honestly don't mind replacing to go-frs/uuid if we're happy that would work. Just need to decide the version value to go with.

[lunny]

what do you think of hosting such gitea-related/maintained shims & forks on gitea.com?

Happy to move these to gitea.com if preferred.

I think we could even consider hosting them on the system.

looked at this lib too, i fafour googl/uuid

Unfortunately we can't force the go-frs/uuid code to use the same shim we'd have to create another one.

I honestly don't mind replacing to go-frs/uuid if we're happy that would work. Just need to decide the version value to go with.

Ah, please!!!