short ciruit the loop if it's not executable (#427)

* short ciruit the loop if it's not executable * fix release drafter commitish
go-nv · Dec 20, 2024 · bc184a9 · bc184a9
1 parent 2cfea4a
commit bc184a9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/release-drafter.yml b/.github/workflows/release-drafter.yml
@@ -47,7 +47,8 @@ jobs:
       # Drafts your next Release notes as Pull Requests are merged into "master"
       - uses: release-drafter/release-drafter@v6
         # (Optional) specify config name to use, relative to .github/. Default: release-drafter.yml
-        # with:
+        with:
+          commitish: master
         #   config-name: my-config.yml
         #   disable-autolabeler: true
         env:

diff --git a/libexec/goenv-commands b/libexec/goenv-commands
@@ -37,17 +37,18 @@ shopt -s nullglob
 
   for path in "${paths[@]}"; do
     for command in "${path}/goenv-"*; do
-      command="${command##*goenv-}"
+      [ -x "$command" ] || continue
+      command="${command##*/goenv-}"
       if [ -n "$sh" ]; then
-        if [ ${command:0:3} = "sh-" ]; then
-          echo ${command##sh-}
+        if [ ${command:0:3} == "sh-" ]; then
+          echo "${command##sh-}"
         fi
       elif [ -n "$nosh" ]; then
         if [ ${command:0:3} != "sh-" ]; then
-          echo ${command##sh-}
+          echo "${command##sh-}"
         fi
       else
-        echo ${command##sh-}
+        echo "${command##sh-}"
       fi
     done
   done