-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support of go1.19 #1558
Drop support of go1.19 #1558
Conversation
WalkthroughThis update focuses on enhancing compatibility and performance by upgrading the required Go version to 1.20, shifting MariaDB support from version 10.3 to 10.5, and introducing support for TiDB by PingCAP. It also includes a technical adjustment in the connection management code by changing the type of a variable for improved atomic operations. Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
go.mod
is excluded by:!**/*.mod
Files selected for processing (2)
- README.md (1 hunks)
- connection.go (2 hunks)
Additional comments: 6
connection.go (2)
- 20-20: The addition of the
sync/atomic
package is appropriate for utilizingatomic.Bool
in the codebase.- 45-45: Changing the
closed
field to useatomic.Bool
from the standard library simplifies the code and improves maintainability by eliminating the customatomicBool
implementation. All usages of theclosed
field have been correctly updated to use theatomic.Bool
methods.README.md (4)
- 44-44: The README now specifies Go 1.20 or higher as a requirement, aligning with the PR's objective to utilize features from newer Go versions. This change is crucial for users and developers to understand the updated environment requirements.
- 44-44: MariaDB support has been updated from version 10.3 to 10.5. This is an important update for users working with MariaDB, ensuring compatibility with newer versions of the database.
- 44-44: Support for TiDB by PingCAP has been added. This inclusion broadens the driver's compatibility with different database systems, offering more options for users.
- 44-44: The README mentions support for MySQL (5.7+) and MariaDB (10.5+), but it's also worth noting in the review that ensuring compatibility with these versions is crucial for users relying on specific database features or behaviors.
Description
Due to the discontinuation of support for Go 1.19 (in #1557 ), we are now able to use the atomic.Bool from the standard library.
This allows us to remove our custom implementation of
atomicBool
and simplify the code.Checklist
Summary by CodeRabbit