Fix for issue #1666

[bdollma-te]

Null termination strip from authData in case of promotion

Description

Address the issue presented in #1666

Checklist

• Code compiles correctly
• Created tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary
• Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

• Documentation

  • Added Bes Dollma from ThousandEyes to the AUTHORS file.

• Tests

  • Updated authentication-related test cases.

• Bug Fixes

  • Improved data handling in the authentication process to ensure proper handling of authentication data.

[coderabbitai]

Walkthrough

This pull request introduces updates to the AUTHORS file by adding a new individual contributor, Bes Dollma, and the organization ThousandEyes. Additionally, it modifies the readAuthResult method in the packets.go file to conditionally trim a trailing zero byte from the authData slice. These changes enhance the contributor documentation and improve the handling of authentication data.

Changes

File	Change Summary
AUTHORS	Added Bes Dollma ([email protected]) and ThousandEyes organization
packets.go	Modified readAuthResult method to conditionally trim the last byte of authData if it is zero
auth_test.go	Updated multiple test cases for authentication switch and caching SHA256 password scenarios

Possibly related PRs

• Check if MySQL supports CLIENT_CONNECT_ATTRS before sending client attributes. #1640: This PR mentions adding an author to the AUTHORS file, which directly relates to the changes made in the main PR regarding the addition of Bes Dollma and ThousandEyes to the AUTHORS file.
• stmt.Close() returns nil when double close #1642: Similar to Check if MySQL supports CLIENT_CONNECT_ATTRS before sending client attributes. #1640, this PR also includes adding the author or copyright holder to the AUTHORS file, indicating a direct connection to the changes made in the main PR.
• Add error 1290/ER_READ_ONLY_MODE to rejectReadOnly handling #1660: This PR also notes that the author has added themselves or the copyright holder to the AUTHORS file, linking it to the main PR's changes.

Suggested reviewers

• methane

Poem

🐰 A rabbit's tale of code so bright,
Contributors join with pure delight,
Packets dance with newfound grace,
Authors list grows, a welcoming space!
Code evolves, one slice at a time 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90fc6d2 and e5d765e.

📒 Files selected for processing (1)

• packets.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packets.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coveralls]

coverage: 83.073% (+0.01%) from 83.06%
when pulling e5d765e on bdollma-te:fix-1666
into 85c6311 on go-sql-driver:master.

[methane]

I confirmed that master branch failed to caching_sha2_password fast auth path and this PR fix it.