AddonLifecycle Performance Enhancement #1834
Conversation
|
Marked as draft for now, as FFXIV is currently down for All Worlds Maintenance. |
|
Ready for merge, tested and verified working. ffxiv_dx11_ycd10wbrXL.mp4This should also help mitigate an issue reported on Linux with reloaded causing noticeable game lag, as hooks will only be generated when requested by a plugin. |
| this.AddonOnRefresh = sig.ScanText("48 89 5C 24 08 57 48 83 EC 20 41 8B F8 48 8B DA"); | ||
| this.AtkEventListener = sig.GetStaticAddressFromSig("4C 8D 3D ?? ?? ?? ?? 49 8D 8E"); | ||
| this.AtkUnitBase = (AtkUnitBase*)sig.GetStaticAddressFromSig("48 8D 05 ?? ?? ?? ?? 48 89 01 48 8D 05 ?? ?? ?? ?? 4C 89 41 28"); |
There was a problem hiding this comment.
Can these sigs be moved to CS proper?
There was a problem hiding this comment.
The callsite sigs can not, as those are for very specific code points.
AddonOnRequestedUpdate is likely already in clientstructs. It's one of the virtual functions for AtkUnitManager.
AtkUnitBase's vtable might already be in clientstructs now that I think about it.
There was a problem hiding this comment.
It doesn't seem that clientstructs has a address for AtkUnitBase's vtable from what I can tell. I'll see about switching requestedupdate, but I think that's the most I can do.
There was a problem hiding this comment.
I was only able to remove AtkUnitBase, the only other one we can remove is OnRefresh, but currently ClientStructs has the wrong function signature, and that will cause issues, so it's on hold for now.
|
aers/FFXIVClientStructs#926 has been merged into ClientStructs When this updated ClientStructs is merged into Dalamud, I can remove the |
Co-authored-by: MidoriKami <[email protected]>
Per Aers' somewhat obvious question in hindsight... ("Why do you need to hook it before its requested?"), I have tweaked it slightly to instead store the address of the ReceiveEvent function, and now only hooks it when it is requested by someone.