CR feedback

gobitfly · Oct 28, 2024 · fcdea36 · fcdea36
1 parent 4340a77
commit fcdea36
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/backend/pkg/api/data_access/vdb_blocks.go b/backend/pkg/api/data_access/vdb_blocks.go
@@ -46,7 +46,7 @@ func (d *DataAccessService) GetValidatorDashboardBlocks(ctx context.Context, das
 	searchGroup := regexp.MustCompile(`^[a-zA-Z0-9_\-.\ ]+$`).MatchString(search)
 	searchIndex := regexp.MustCompile(`^[0-9]+$`).MatchString(search)
 
-	validators := goqu.T("validators")
+	validators := goqu.T("validators") // could adapt data type to make handling as table/alias less confusing
 	blocks := goqu.T("blocks")
 	groups := goqu.T("groups")
 
@@ -215,6 +215,8 @@ func (d *DataAccessService) GetValidatorDashboardBlocks(ctx context.Context, das
 		if err == nil {
 			if dashboardId.Validators == nil {
 				// fetch filtered validators if not done yet
+				filteredValidatorsDs = filteredValidatorsDs.
+					SelectAppend(groupIdQ)
 				validatorsQuery, validatorsArgs, err := filteredValidatorsDs.Prepared(true).ToSQL()
 				if err != nil {
 					return nil, nil, err