Beds 849/adjust discord webhooks #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisei24
commented
Oct 22, 2024
| @@ -1942,10 +1940,13 @@ func (d *DataAccessService) GetNotificationSettingsDashboards(ctx context.Contex | |||
| resultMap[key].ChainIds = []uint64{valDashboard.Network} | |||
|
|
|||
| // Set the settings | |||
| if valSettings, ok := resultMap[key].Settings.(*t.NotificationSettingsValidatorDashboard); ok { | |||
There was a problem hiding this comment.
I noticed that we had a bug here (and the acc dashboard equivalent below).
The Settings are not a pointer so the type check never worked and we never got the correct webhook (& realtime mode) info, just the default WebhookUrl = "", IsWebhookDiscordEnabled = false.
Deploying beaconchain with
|
| Latest commit: |
af51fa4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://924ebc6b.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-849-adjust-discord-webh.beaconchain.pages.dev |
peterbitfly
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.