Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocket Pool Dashboard List #1161

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Rocket Pool Dashboard List #1161

merged 1 commit into from
Dec 12, 2024

Conversation

manuelsc
Copy link
Contributor

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6c57c8c
Status: ✅  Deploy successful!
Preview URL: https://6bdb01de.beaconchain.pages.dev
Branch Preview URL: https://beds-981-rocketpool-dashboar.beaconchain.pages.dev

View logs

@manuelsc manuelsc force-pushed the BEDS-981/rocketpool-dashboard branch 2 times, most recently from b5b3ad7 to ff633d8 Compare November 25, 2024 15:00
Copy link
Contributor

@remoterami remoterami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments/thoughts, ptal

backend/pkg/api/data_access/mobile.go Show resolved Hide resolved
backend/pkg/api/data_access/vdb_rocket_pool.go Outdated Show resolved Hide resolved
backend/pkg/api/data_access/vdb_rocket_pool.go Outdated Show resolved Hide resolved
@manuelsc manuelsc force-pushed the BEDS-981/rocketpool-dashboard branch 2 times, most recently from db59520 to 316e1ef Compare December 11, 2024 09:33
Copy link
Contributor

@remoterami remoterami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just fix CI tasks please (FE type conversion)

perf: use new validator index for rocket pool mobile queries instead of pubkey

feat: add total node deposit balance, total user deposit balance
@manuelsc manuelsc force-pushed the BEDS-981/rocketpool-dashboard branch from 760254f to 6c57c8c Compare December 12, 2024 10:16
@manuelsc manuelsc merged commit 3e1a8fd into staging Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants