(BEDS-1052) VDB: validator search by hex graffiti #1229
Conversation
remoterami
force-pushed
the
BEDS-1052/vdb-hex-graffiti
branch
from
ff20945 to
672d573
Compare
Deploying beaconchain with
|
| Latest commit: |
f698e55
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://476864b7.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-1052-vdb-hex-graffiti.beaconchain.pages.dev |
remoterami
force-pushed
the
BEDS-1052/vdb-hex-graffiti
branch
from
672d573 to
f698e55
Compare
| reGraffiti = regexp.MustCompile(`^.{2,}$`) // at least 2 characters, so that queries won't time out | ||
| reCursor = regexp.MustCompile(`^[A-Za-z0-9-_]+$`) // has to be base64 | ||
| reGraffiti = regexp.MustCompile(`^.{2,}$`) // at least 2 characters, so that queries won't time out | ||
| reGraffitiHex = regexp.MustCompile(`^(0x)?([0-9a-fA-F]{2}){2,}$`) // at least 2 bytes, so that queries won't time out |
There was a problem hiding this comment.
Question: Should this be a valid hex input?
> curl --location 'http://0.0.0.0:8081/api/i/search' \
--header 'Content-Type: application/json' \
--data '{
"input":"0x0000000000000000000000000000000000000000000000000000000000000000",
"networks":["holesky"]
}'
{"data":[{"type":"validators_by_graffiti","chain_id":17000,"value":{"graffiti":"","hex":"0x0000000000000000000000000000000000000000000000000000000000000000","count":72496}}]}There was a problem hiding this comment.
Good question, clarified and the answer is "yes can do that for now". Can exclude empty graffitis later if we run into issues.
There was a problem hiding this comment.
Issue: Frontend would pass the graffiti string, not hex, to the endpoint for adding validators to a dashboard by their graffiti and passing an empty graffiti counts as not passing it at all. See:
I believe we have to forbid empty graffitis
There was a problem hiding this comment.
Bummer! Applied, needs explicit handling though since look-arounds aren't a thing in go's regexp
|
I added some validation checks for maximum graffiti size of 32 bytes (which actually is a chain parameter but I doubt anyone would be messing with this..). |
| reGraffiti = regexp.MustCompile(`^.{2,}$`) // at least 2 characters, so that queries won't time out | ||
| reCursor = regexp.MustCompile(`^[A-Za-z0-9-_]+$`) // has to be base64 | ||
| reGraffiti = regexp.MustCompile(`^.{2,}$`) // at least 2 characters, so that queries won't time out | ||
| reGraffitiHex = regexp.MustCompile(`^(0x)?([0-9a-fA-F]{2}){2,}$`) // at least 2 bytes, so that queries won't time out |
There was a problem hiding this comment.
Issue: Frontend would pass the graffiti string, not hex, to the endpoint for adding validators to a dashboard by their graffiti and passing an empty graffiti counts as not passing it at all. See:
I believe we have to forbid empty graffitis
No description provided.