Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEDS-175 / missed rewards for group summary #1238

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

sasha-bitfly
Copy link
Contributor

@sasha-bitfly sasha-bitfly commented Jan 8, 2025

Added missed cl rewards, missed sync rewards , missed attestations rewards for group summary

Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2025

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8dd7fb2
Status: ✅  Deploy successful!
Preview URL: https://7b159ee4.beaconchain.pages.dev
Branch Preview URL: https://beds-175-missed-rewards-in-s.beaconchain.pages.dev

View logs

@sasha-bitfly sasha-bitfly force-pushed the BEDS-175/missed-rewards-in-summary-table branch 2 times, most recently from 8c09ec5 to 0cda6da Compare January 9, 2025 18:16
Copy link
Contributor

@remoterami remoterami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data access lgtm so far; but need to clarify what happens to missing el proposer rewards

backend/pkg/api/data_access/vdb_summary.go Outdated Show resolved Hide resolved
@sasha-bitfly sasha-bitfly force-pushed the BEDS-175/missed-rewards-in-summary-table branch from 0cda6da to 3b4724f Compare January 10, 2025 17:34
@sasha-bitfly
Copy link
Contributor Author

sasha-bitfly commented Jan 10, 2025

Data access lgtm so far; but need to clarify what happens to missing el proposer rewards

@remoterami Missed EL rewards will be added separately. Invis came with a formula yesterday, I am validating it.

Copy link
Contributor

@remoterami remoterami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sounds good 👍

@sasha-bitfly sasha-bitfly merged commit abddc5f into staging Jan 13, 2025
3 checks passed
@sasha-bitfly sasha-bitfly deleted the BEDS-175/missed-rewards-in-summary-table branch January 13, 2025 16:54
@sasha-bitfly sasha-bitfly restored the BEDS-175/missed-rewards-in-summary-table branch January 16, 2025 14:48
@sasha-bitfly sasha-bitfly deleted the BEDS-175/missed-rewards-in-summary-table branch January 16, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants