Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BEDS 1124/prices #1258

Merged
merged 2 commits into from
Jan 14, 2025
Merged

BEDS 1124/prices #1258

merged 2 commits into from
Jan 14, 2025

Conversation

LuccaBitfly
Copy link
Contributor

  • refactor: generalize util slice dedupe
  • fix: show correct exchange rates for gnosis

remoterami
remoterami requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@remoterami remoterami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prices more accurate than Binance 👍 Some minor comments, ptal

backend/pkg/api/data_access/header.go Show resolved Hide resolved
backend/pkg/api/services/service.go Show resolved Hide resolved
backend/pkg/commons/price/price.go Show resolved Hide resolved
backend/pkg/commons/price/price.go Outdated Show resolved Hide resolved
@LuccaBitfly LuccaBitfly force-pushed the BEDS-1124/prices branch 2 times, most recently from 73a1164 to e5499c1 Compare January 14, 2025 08:57
remoterami
remoterami approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@remoterami remoterami left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Unrelated to your changes, but in addPricePairs (which you merged) I think that pricesCopy doesn't really do anything (bcus maps are ref types in go, can't create a deep copy like that). If you agree you could clean that up, but shouldn't cause any harm if not. See https://github.com/gobitfly/beaconchain/pull/1258/files#diff-b341d664d42e9927a41a4d294042b57ffd5461d62357ed14e6022352b5f840b0R158

@LuccaBitfly LuccaBitfly merged commit 37e0dbf into staging Jan 14, 2025
2 checks passed
@LuccaBitfly LuccaBitfly deleted the BEDS-1124/prices branch January 14, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remoterami remoterami remoterami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuccaBitfly @remoterami