Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BEDS-1116) internal subscription grace period #1263

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

remoterami
Copy link
Contributor

@remoterami remoterami commented Jan 13, 2025

A convention involving the unused column users_app_subscriptions.expires_at in combination with the active flag is introduced: when a subscription is active and it expired in the past, it’s currently in a grace period. That’s less effort than adding a new inGracePeriod column or something. Should be merged along with gobitfly/eth2-beaconchain-explorer#2998 for stripe.

This was mostly a research task; see payment provider docs for reference:

  • Google: subscription end date returned from API changes dynamically based on state, need internal handling
  • Apple: Currently used field is correct, there's another one for grace periods (gracePeriodExpirationDate)
  • Stripe: Currently the constant 0 is written as end, need to change. More context

Note that for existing subscriptions this feature can only be ensured to work after the user made an update (e.g. paid an invoice, changed plans etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant