Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEDS-1165 / fix missed el rewards in group summary for a period #1288

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

sasha-bitfly
Copy link
Contributor

@sasha-bitfly sasha-bitfly commented Jan 21, 2025

Missed el rewards is constant and the same for a period last_1h, all_time

https://v2-staging-holesky.beaconcha.in/api/i/validator-dashboards/v-80d7edaa-74fb-4129-a41e-7700756961cf/groups/-1/summary?period=last_1h

https://v2-staging-holesky.beaconcha.in/api/i/validator-dashboards/v-80d7edaa-74fb-4129-a41e-7700756961cf/groups/-1/summary?period=all_time

For both API calls:

"missed_rewards": {
  "proposer_rewards": {
    "el": "33672441519334000000"

clickhouse table was picked for all_time period always, the fix is to pick clickhouse table name depending on a period

@sasha-bitfly sasha-bitfly merged commit a5d1d36 into staging Jan 22, 2025
2 checks passed
@sasha-bitfly sasha-bitfly deleted the BEDS-1165/missed-el-rewards-for-period branch January 22, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants