Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beds 1037/large dashboards should not load slot viz icons and absolute values #1303

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Beds 1037/large dashboards should not load slot viz icons and absolute values #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
17af0b2
refactor: move composable into `validatorDashboardOverviewStore`
enzo-bitfly Jan 17, 2025
dde2724
refactor: improve `slotviz` section's component structure and namings
enzo-bitfly Jan 24, 2025
aac86f0
perf: prevent unnecessary request for `slotviz` data before setting g…
enzo-bitfly Jan 24, 2025
1984d4e
feat: calculate and persist `slotviz` visible duties
enzo-bitfly Jan 28, 2025
6391170
feat(DashboardTableSummary): calculate and persist initial values' unit
enzo-bitfly Jan 28, 2025
951a175
refactor(DashboardTableSummary): reorganize component for better read…
enzo-bitfly Jan 29, 2025
e2c3d79
fix(DashboardSlotViz): prevent horizontal scrollbar on full width
enzo-bitfly Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/.vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
"DashboardChartSummary",
"DashboardChartSummaryFilter",
"DashboardGroupManagementModal",
"DashboardSlotViz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np: commit msg
(refactor(DashboardSlotViz): improve component structure and namings)

We should use the scope as a hint that this commit's changes are limited to the named slot 👉DashboardSlotViz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rephrased the commit message and removed the scope

"DashboardTableSummary",
"DashboardTableSummaryDetails",
"DashboardTableSummaryValue",
"DashboardTableValidators",
Expand All @@ -33,7 +35,6 @@
"NotificationsNetworkTable",
"NotificationsOverview",
"NotificationsTableEmpty",
"SlotVizViewer",
"a11y",
"checkout",
"ci",
Expand Down
6 changes: 4 additions & 2 deletions frontend/components/dashboard/DashboardValidatorManagementModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@ const dialog = useDialog()
const visible = defineModel<boolean>()
const validatorDashboardOverviewStore = useValidatorDashboardOverviewStore()
const {
overview, refreshOverview,
} = useValidatorDashboardOverviewStore()
overview,
} = storeToRefs(validatorDashboardOverviewStore)
const { refreshOverview } = validatorDashboardOverviewStore
const cursor = ref<Cursor>()
const pageSize = ref<number>(25)
Expand Down
3 changes: 2 additions & 1 deletion frontend/components/dashboard/DashboardValidatorManagementModalSearch.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ const { t: $t } = useTranslation()

const input = defineModel<string>()

const validatorDashboardOverviewStore = useValidatorDashboardOverviewStore()
const {
overview,
} = useValidatorDashboardOverviewStore()
} = storeToRefs(validatorDashboardOverviewStore)
const { chainIdByDefault } = useRuntimeConfig().public

const currentDashboardNetwork = computed(() => overview.value?.network ?? chainIdByDefault)
Expand Down
3 changes: 2 additions & 1 deletion frontend/components/dashboard/DashboardValidatorOverview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ import { DashboardValidatorSubsetModal } from '#components'
const { t: $t } = useTranslation()
const { converter } = useValue()

const { overview } = useValidatorDashboardOverviewStore()
const validatorDashoboardOverviewStore = useValidatorDashboardOverviewStore()
const { overview } = storeToRefs(validatorDashoboardOverviewStore)

const formatValueWei = (value: NumberOrString): NumberOrString => {
return converter.value.weiToValue(`${value}`, { fixedDecimalCount: 4 })
Expand Down
145 changes: 0 additions & 145 deletions frontend/components/dashboard/ValidatorSlotViz.vue
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion frontend/components/dashboard/chart/DashboardChartSummary.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ const {
secondsPerEpoch,
} = useNetworkStore()
const { dashboardKey } = useDashboardKey()
const { overview } = useValidatorDashboardOverviewStore()
const validatorDashboardOverviewStore = useValidatorDashboardOverviewStore()
const { overview } = storeToRefs(validatorDashboardOverviewStore)
const { groups } = useValidatorDashboardGroups()
const { latestState } = useLatestStateStore()
const latestSlot = ref(latestState.value?.current_slot || 0)
Expand Down
4 changes: 2 additions & 2 deletions frontend/components/dashboard/chart/DashboardChartSummaryFilter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ import {
import { getGroupLabel } from '~/utils/dashboard/group'

const { t: $t } = useTranslation()

const validatorDashboardOverviewStore = useValidatorDashboardOverviewStore()
const {
hasAbilityCharthistory,
overview,
} = useValidatorDashboardOverviewStore()
} = storeToRefs(validatorDashboardOverviewStore)

const chartFilter = defineModel<SummaryChartFilter>({ required: true })

Expand Down
Loading