(BIDS-3095) revamp adding validators to dashboard #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying beaconchain with
|
| Latest commit: |
36c515d
|
| Status: | 🚫 Build failed. |
thib-wien
reviewed
Jun 5, 2024
| Input string `json:"input"` | ||
| Networks []network `json:"networks,omitempty"` | ||
| Types []searchTypeKey `json:"types,omitempty"` | ||
| IncludeValidators bool `json:"include_validators,omitempty"` |
There was a problem hiding this comment.
Dear Lucca,
I might be wrong but I think that you do not let anymore the front-end tell the API whether counting is needed.
When the request comes from the general search bar, a count is not needed (as far as I know). To save resources, maybe you want to keep this boolean in the spec, so you count only if we set it to true.
There was a problem hiding this comment.
getting the count was the alternative to getting the validator indices, i.e. even in the old system it was always planned to return the count when setting include_validators to false. fetching the count is not that resource intensive, so it should be fine.
recy21
approved these changes
Jun 5, 2024
peterbitfly
requested changes
Jun 6, 2024
| } | ||
| err := db.ReaderDb.Select(&ret.Validators, "select distinct proposer from blocks where graffiti_text = $1 limit 10;", graffiti) // added a limit here to keep the query fast | ||
| err := db.ReaderDb.Get(&ret.Count, "select count(distinct proposer) from blocks where graffiti_text = $1;", graffiti) // added a limit here to keep the query fast |
There was a problem hiding this comment.
the comment is obsolete now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.