Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider quantity for addon price #480

Merged
merged 2 commits into from
Jun 14, 2024
Merged

consider quantity for addon price #480

merged 2 commits into from
Jun 14, 2024

Conversation

MauserBitfly
Copy link
Contributor

This PR

  • takes the quantity into account for the addon price displays on the pricing pages

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jun 14, 2024 •
edited
Loading

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2d86a2
Status: ✅  Deploy successful!
Preview URL: https://3138d7cf.beaconchain.pages.dev
Branch Preview URL: https://bids-3134-prcing-addon-based.beaconchain.pages.dev

View logs

D13ce
D13ce suggested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be considered done, but found a bug. PTAL below 👇

frontend/components/pricing/PremiumAddonBox.vue Outdated Show resolved Hide resolved
@MauserBitfly MauserBitfly requested a review from D13ce June 14, 2024 07:36
D13ce
D13ce approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MauserBitfly MauserBitfly merged commit faf587c into main Jun 14, 2024
2 checks passed
@MauserBitfly MauserBitfly deleted the BIDS-3134/prcing-addon-based-on-quantity branch June 14, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D13ce D13ce D13ce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MauserBitfly @D13ce