mega menu - fixing click area #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thib-wien
suggested changes
Jun 14, 2024
| const available = computed<Currency[]>(() => { | ||
| const list: Currency[] = [networkInfo.value.elCurrency] | ||
| watch(latestState, () => { | ||
| let list: Currency[] = [networkInfo.value.elCurrency] |
There was a problem hiding this comment.
In the future, when the user switches between networks, the list of available currencies might stay outdated for a few seconds until the rates changes.
I am thinking about a switch between Gnosis (GNO + xDAI) and Ethereum (where these currencies might not be listed) for example.
A possible fix would be on line 31:
watch([latestState,networkInfo], () => {There was a problem hiding this comment.
makes sense - changed!
Deploying beaconchain with
|
| Latest commit: |
492b263
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c41adfa.beaconchain.pages.dev |
| Branch Preview URL: | https://bids-3136-megamenu-click-ere.beaconchain.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: