Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NOBIDS) small fix in the logic of getUser() #483

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

thib-wien
Copy link
Contributor

@thib-wien thib-wien commented Jun 14, 2024

If undefined data was received from the API, getUser() would return undefined to inform useAsyncData that it must recall the API from the client.
The user was not set to undefined in the meantime. This was a mistake.

Also:
The bottom border of the header should be visible when NUXT_PUBLIC_SHOW_IN_DEVELOPMENT is "false" and the screen is large.
It was not the case. Fixed.

Copy link

cloudflare-workers-and-pages bot commented Jun 14, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 93a5429
Status: ✅  Deploy successful!
Preview URL: https://1c35081f.beaconchain.pages.dev
Branch Preview URL: https://nobids-some-performance-impr.beaconchain.pages.dev

View logs

Copy link
Contributor

@MauserBitfly MauserBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thib-wien thib-wien merged commit a488f80 into main Jun 14, 2024
2 checks passed
@thib-wien thib-wien deleted the NOBIDS/some-performance-improvements branch June 14, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants