Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BIDS-2959) pressing Enter or the + button does not bypass premium restrictions anymore #485

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

thib-wien
Copy link
Contributor

@thib-wien thib-wien commented Jun 14, 2024

To test it:

  1. In the management modal, perform a premium-restricted search, for example 0x778F5F13C4Be78A3a4d7141BCB26999702f407CF.
  2. Press Enter or +.
  3. The UI does not react anymore. The dropdown stays open and shows the premium diamonds.

If you set mock: true in types/customFetch.ts, then you can test what happens when the dropdown contains a mix of premium and non-premium results:
the premium rows are skipped when the user presses Enter or +, the first non-premium row gets added to the dashboard.

@thib-wien thib-wien changed the title (BIDS-2959) pressing Enter or the + button does not bypass premium-restricted results anymore (BIDS-2959) pressing Enter or the + button does not bypass premium restrictions anymore Jun 14, 2024
Copy link

cloudflare-workers-and-pages bot commented Jun 14, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: b188d2e
Status: ✅  Deploy successful!
Preview URL: https://08aa27e3.beaconchain.pages.dev
Branch Preview URL: https://bids-2959-landing-searchfron.beaconchain.pages.dev

View logs

Copy link
Contributor

@MauserBitfly MauserBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thib-wien thib-wien merged commit 280e22f into main Jun 17, 2024
2 checks passed
@thib-wien thib-wien deleted the BIDS-2959/Landing-SearchFrontend branch June 17, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants